BrowZine covers: skip over default images. #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maccabeelevine
requested changes
Feb 12, 2025
There was a problem hiding this comment.
This works and is a very nice improvement, I have seen that fake journal cover so many times and although it confused me I never put together that it was a default. Better to let a backup source provide a real one.
I agree that the URL should be externalized in config, just in case.
|
Thanks, @maccabeelevine, I've added the requested configurability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the BrowZine cover API returns a default image, which will prevent other cover providers from being chained together. This PR skips over default images so that VuFind can handle defaults on its end.